Skip to content

postprocess: Add cronjob test c2rust-postprocess#1857

Draft
Crocodoctopus wants to merge 1 commit into
masterfrom
bg/add-postprocess-ci-test
Draft

postprocess: Add cronjob test c2rust-postprocess#1857
Crocodoctopus wants to merge 1 commit into
masterfrom
bg/add-postprocess-ci-test

Conversation

@Crocodoctopus

Copy link
Copy Markdown
Contributor

Test PR c2rust-postprocess testing in CI.

The basic idea is to run a daily cronjob running c2rust-postprocess on json-c with a real API key and with --on-error keep-going, generating new cache entries. PR CI runners will run their postprocess tests with under cache only with --on-error warn. This will have the side effect that breaking changes to c2rust-postprocess that still work under --on-error warn will only become apparent during the daily cronjob.

@Crocodoctopus Crocodoctopus force-pushed the bg/add-postprocess-ci-test branch from 84808f3 to 3a95eb4 Compare June 16, 2026 20:27
@thedataking thedataking changed the title wip, postprocess: Add postprocess test cronjob postprocess: Add postprocess test cronjob Jun 16, 2026
@thedataking thedataking changed the title postprocess: Add postprocess test cronjob postprocess: Add cronjob test c2rust-postprocess Jun 16, 2026
Comment thread .github/workflows/internal-testsuite.yml Outdated
Comment thread .github/workflows/internal-testsuite.yml Outdated

@thedataking thedataking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing: using the Github cache action to restore and save c2rust-postprocessor entries on the cronjob or PR runs. If that's why the PR is marked draft, no worries.

Comment thread .github/workflows/internal-testsuite.yml Outdated
@Crocodoctopus Crocodoctopus force-pushed the bg/add-postprocess-ci-test branch 2 times, most recently from 24ae5c6 to 1d7e507 Compare June 16, 2026 23:50
@Crocodoctopus

Copy link
Copy Markdown
Contributor Author

Most of this is pretty hacked together, I'll address feedback as it stabilizes.

@Crocodoctopus Crocodoctopus force-pushed the bg/add-postprocess-ci-test branch 18 times, most recently from 5a09690 to 918a280 Compare June 23, 2026 07:09
@Crocodoctopus Crocodoctopus force-pushed the bg/add-postprocess-ci-test branch from 918a280 to ab63ac0 Compare June 23, 2026 08:54
@Crocodoctopus

Copy link
Copy Markdown
Contributor Author

Currently, the cronjob launches the same way as the c2rust-testsuite workflow to ensure the latter can access the former's cache (for testing). When the cronjob hits master, on-pr and on-push workflows should have access to that cache as well(?). Tests show c2rust-testsuite/run-testsuite is using cached data from the cronjob, which runs postprocess on json_object_set_userdata and json_object_to_file.

Most real changes are in .github/workflows/daily-cronjobs.yml, almost every other change is temporary; I tried to keep TODOs for each change that shouldn't be reviewed. I'm leaving this draft until all temporaries are gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants